Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem in MakeInputIterator() #6667

Closed
cighao opened this issue Apr 8, 2020 · 1 comment
Closed

A problem in MakeInputIterator() #6667

cighao opened this issue Apr 8, 2020 · 1 comment

Comments

@cighao
Copy link
Contributor

cighao commented Apr 8, 2020

For function MakeInputIterator() in version_set.cc

image

when call NewIterator(), the level parameters should be that which level *flevel->files[i].file_metadata belongs to. But the variable which is only the index. which value is 0, 1, 2,3..., it does not mean level number. The level number should be c->level(which)

Could you please check that? Is it my misunderstanding?

@wolfkdy
Copy link
Contributor

wolfkdy commented Apr 9, 2020

It seems a dangerous typo, I looked deeper into the code to see how which (the level param) affects NewIterator, it seems currently, this param is not used in the following process.

facebook-github-bot pushed a commit that referenced this issue Jun 3, 2020
Summary:
fix these two issues #6912  and #6667
Pull Request resolved: #6920

Reviewed By: cheng-chang

Differential Revision: D21864885

Pulled By: ajkr

fbshipit-source-id: 10e21fc1851b67a59d44358f59c64fa5523bd263
@ajkr ajkr closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants