Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double-lock in WriteImplWALOnly #7197

Closed
jonahgao opened this issue Jul 29, 2020 · 1 comment
Closed

double-lock in WriteImplWALOnly #7197

jonahgao opened this issue Jul 29, 2020 · 1 comment

Comments

@jonahgao
Copy link
Contributor

jonahgao commented Jul 29, 2020 •
edited
Loading

In WriteImplWALOnly, mutex_ is locked twice, cause deadlock.

First time:

rocksdb/db/db_impl/db_impl_write.cc

Line 689 in d9d1907

InstrumentedMutexLock l(&mutex_);

Then the second one in the call of WriteStatusCheck:

rocksdb/db/db_impl/db_impl_write.cc

Line 838 in d9d1907

mutex_.Lock();

@zhichao-cao
Copy link
Contributor

Hi @byteink , you are right, will create a PR to fix it. Thanks for pointing out it!

@zhichao-cao zhichao-cao mentioned this issue Jul 29, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue Aug 7, 2020
@zhichao-cao @facebook-github-bot
Fix the potential deadlock in WriteImplWALOnly and UnorderedWriteMemt…
b79f13b 
…able (#7199)

Summary:
Pointed out by #7197 , there is a double lock in WriteImplWALOnly.
Also find another deadlock in UnorderedWriteMemtable. Move the check after switch_all_.notify_all().

Pull Request resolved: #7199

Test Plan: pass make check

Reviewed By: anand1976

Differential Revision: D22961714

Pulled By: zhichao-cao

fbshipit-source-id: 0707922dc50d28ea141a15a8cdcbd1c8993ea0d8
@jonahgao jonahgao closed this as completed Aug 9, 2020
codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this issue Mar 5, 2021
@zhichao-cao @codingrhythm
Fix the potential deadlock in WriteImplWALOnly and UnorderedWriteMemt…
f1fad3c 
…able (facebook#7199)

Summary:
Pointed out by facebook#7197 , there is a double lock in WriteImplWALOnly.
Also find another deadlock in UnorderedWriteMemtable. Move the check after switch_all_.notify_all().

Pull Request resolved: facebook#7199

Test Plan: pass make check

Reviewed By: anand1976

Differential Revision: D22961714

Pulled By: zhichao-cao

fbshipit-source-id: 0707922dc50d28ea141a15a8cdcbd1c8993ea0d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhichao-cao @jonahgao