-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion]let IncreaseFullHistoryTsLow be a public API #9210
Comments
@wolfkdy this sounds a reasonable ask. We avoided doing so in our first attempt because we wanted to defer the addition of public APIs. Also, the current implementation of increasing |
@riversand963 Thanks, we'll try to post an mr in a week.
I think this can be resolved by also making the |
@riversand963 |
Summary: As (#9210) discussed, the **full_history_ts_low** is a member of CompactRangeOptions currently, which means a CF's fullHistoryTsLow is advanced only when users submit a CompactRange request. However, users may want to advance the fllHistoryTsLow without an immediate compact. This merge make IncreaseFullHistoryTsLow to a public API so users can advance each CF's fullHistoryTsLow seperately. Pull Request resolved: #9221 Reviewed By: akankshamahajan15 Differential Revision: D33201106 Pulled By: riversand963 fbshipit-source-id: 9cb1d013ba93260f72e16353e693ffee167b47ee
Currently, the fullHistoryTsLow is a member of CompactRangeOptions, that means a CF's fullHistoryTsLow is advanced only when users submit a CompactRange request.
However, users may want to advance the fllHistoryTsLow without an immediate compact, users may construct a fake range(which actually does not exist in the db, and submit a CompactRange task with the fake range. This should work but not neat.
So, @riversand963 , how about make
IncreaseFullHistoryTsLow
a public API so users can advance each CF's fullHistoryTsLow seperately?The text was updated successfully, but these errors were encountered: