Fix a bug of not setting enforce_single_del_contracts #10027
Conversation
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I am not entirely happy with the test plan, because I would prefer a test which will fail if a similar bug happens in the future. |
There is already a test that builds options from Immutable/MutableOptions (OptionsTest::DBOptionsComposeImmutable). One issue is that the new option is not part of the randomized values in RandomInitDBOptions. It might also be useful if this specific test did multiple runs to allow different random values. |
riversand963
force-pushed
the
fix-single-del-enforce-opts
branch
from
f5c6aab
to
0d08e98
Compare
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
Summary: Before this PR, BuildDBOptions() does not set a newly-added option, i.e. enforce_single_del_contracts, causing OPTIONS files to contain incorrect information. Test Plan: make check
riversand963
force-pushed
the
fix-single-del-enforce-opts
branch
from
0d08e98
to
d619d61
Compare
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
Added to the test. Thanks for the info. My knowledge about options setting should be updated. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This reverts commit 9128a28.
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Before this PR, BuildDBOptions() does not set a newly-added option, i.e.
enforce_single_del_contracts, causing OPTIONS files to contain incorrect
information.
Test Plan:
make check
Manually check OPTIONS file.