Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CircleCI Windows Build #10090

Closed
wants to merge 12 commits into from
Closed

Conversation

jay-zhuang
Copy link
Contributor

@jay-zhuang jay-zhuang commented Jun 1, 2022

  • Upgrade CircleCI orb from 2.4 to 5.0
  • Setup vs2022 build
  • Use image build-in vs2019 and vs2022
  • Remove vs2017
  • Remove CMAKE_CXX_STANDARD=20

@jay-zhuang jay-zhuang force-pushed the win_orb branch 2 times, most recently from aacfa81 to eea4a5b Compare October 28, 2022 02:38
@jay-zhuang jay-zhuang changed the title Upgrade CircleCI Windows orb Upgrade CircleCI Windows Build Oct 28, 2022
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants