Fix potential leak when reusing PinnableSlice instances. #10166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinnableSlice
may hold a handle to a cache value which must be released to correctly decrement the ref-counter. However, whenPinnableSlice
variables are reused, e.g. like this:then the second
Get
simply overwrites the old value inpin_slice
and the handle returned by the firstGet
is not released.This PR adds
Reset
calls to theGet
/MultiGet
calls that acceptPinnableSlice
arguments to ensure proper cleanup of old values.