autovector: performance improves #10230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use union values_ instead of point values_ point to internal buf_ 2. rearrange fields for cpu cache friendly 3. two exception-safe fix 4. delete ~iterator_impl
…red "-Wmaybe-uninitialized"
rockeet
force-pushed
the
autovector.optimize
branch
from
3069705
to
5207e21
Compare
jsteemann
reviewed
Jun 23, 2022
util/autovector.h
Outdated
| value_type)) char buf_[kSize * | ||
| sizeof(value_type)]; // the first `kSize` items | ||
| pointer values_; | ||
| static void destory(value_type* p, size_t n) { |
There was a problem hiding this comment.
Should probably be renamed to destroy (typo in previous method name).
Suggested change
| static void destory(value_type* p, size_t n) { | |
| static void destroy(value_type* p, size_t n) { |
There was a problem hiding this comment.
Done, thanks for your correction!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. this reduces autovector object size
b. this reduces a memory load for pointer value_
c. this makes autovector relocatable(memmoveable) because there is no ptr point to object self