Fix the flaky cursor persist test #10250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlepig2013
force-pushed
the
fix_flaky_cursor_persist_test
branch
from
03dfab2
to
3a1d6ad
Compare
littlepig2013
force-pushed
the
fix_flaky_cursor_persist_test
branch
from
3a1d6ad
to
646f90b
Compare
ajkr
approved these changes
Jun 24, 2022
littlepig2013
force-pushed
the
fix_flaky_cursor_persist_test
branch
from
646f90b
to
6722caf
Compare
|
@littlepig2013 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Jun 24, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: Update HISTORY.md for CompactionPri::kRoundRobin. Detailed implementation can be found in [PR10107](#10107), [PR10227](#10227), [PR10250](#10250), [PR10278](#10278), [PR10316](#10316), and [PR10341](#10341) Pull Request resolved: #10421 Reviewed By: ajkr Differential Revision: D38194070 Pulled By: littlepig2013 fbshipit-source-id: 4ce153dc0bf22cd865d09c5429955023dbc90f37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The 'PersistRoundRobinCompactCursor' unit test in
db_compaction_testmay occasionally fail due to the inconsistent LSM state. The issue is fixed by addingFlush()andWaitForFlushMemTable()to produce a more predictable and stable LSM state.Test: 'PersistRoundRobinCompactCursor' unit test in
db_compaction_test