Pass rate_limiter_priority through filter block reader functions to FS #10251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gitbw95 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gitbw95
changed the title
pdillinger
approved these changes
Jun 24, 2022
| @@ -454,12 +454,14 @@ class BlockBasedTable : public TableReader { | |||
| const bool no_io, | |||
| const SliceTransform* prefix_extractor, | |||
| GetContext* get_context, | |||
| BlockCacheLookupContext* lookup_context) const; | |||
| BlockCacheLookupContext* lookup_context, | |||
| Env::IOPriority rate_limiter_priority) const; | |||
There was a problem hiding this comment.
If we ever have more than two parameters relating to when & how to do I/O if needed (currently no_io and rate_limiter_priority), then I think it would be worth wrapping those into one bundled parameter. But two is OK.
Closed
gitbw95
pushed a commit
to gitbw95/rocksdb
that referenced
this pull request
Jun 28, 2022
facebook#10251) Summary: With facebook#9996 , we can pass the rate_limiter_priority to FS for most cases. This PR is to update the code path for filter block reader. Pull Request resolved: facebook#10251 Test Plan: Current unit tests should pass. Reviewed By: pdillinger Differential Revision: D37427667 Pulled By: gitbw95 fbshipit-source-id: 1ce5b759b136efe4cfa48a6b97e2f837ff087433
pdillinger
pushed a commit
that referenced
this pull request
Jun 28, 2022
#10251) Summary: With #9996 , we can pass the rate_limiter_priority to FS for most cases. This PR is to update the code path for filter block reader. Pull Request resolved: #10251 Test Plan: Current unit tests should pass. Reviewed By: pdillinger Differential Revision: D37427667 Pulled By: gitbw95 fbshipit-source-id: 1ce5b759b136efe4cfa48a6b97e2f837ff087433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With #9996 , we can pass the rate_limiter_priority to FS for most cases. This PR is to update the code path for filter block reader.
Test Plan:
Current unit tests should pass.