Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB #10332

DaMatrix · 2022-07-10T11:34:05Z

This overrides CreateColumnFamilies and DropColumnFamilies in PessimisticTransactionDB in order to add/remove the created column families to/from the lock manager.

Fixes #10322.

…tionDB

riversand963

Thanks @DaMatrix for the fix! Left a few comments.

riversand963 · 2022-07-12T23:49:57Z

utilities/transactions/pessimistic_transaction_db.h

@@ -101,9 +101,21 @@ class PessimisticTransactionDB : public TransactionDB {
                                    const std::string& column_family_name,
                                    ColumnFamilyHandle** handle) override;

+  virtual Status CreateColumnFamilies(


Keep override and remove virtual, per https://releases.llvm.org/9.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-override.html.

riversand963 · 2022-07-12T23:51:40Z

utilities/transactions/pessimistic_transaction_db.cc

+
+  s = db_->CreateColumnFamilies(options, column_family_names, handles);
+  if (s.ok()) {
+    for (auto it = handles->begin(); it != handles->end(); ++it) {


Nit: let's use

assert(handles); for (auto* handle : *handles) { }

riversand963 · 2022-07-12T23:52:40Z

utilities/transactions/pessimistic_transaction_db.cc

+    std::vector<ColumnFamilyHandle*>* handles) {
+  InstrumentedMutexLock l(&column_family_mutex_);
+
+  for (auto it = column_families.begin(); it != column_families.end(); ++it) {


Nit: for (auto* cf_desc : column_families)

riversand963 · 2022-07-12T23:52:56Z

utilities/transactions/pessimistic_transaction_db.cc

+
+  Status s = db_->CreateColumnFamilies(column_families, handles);
+  if (s.ok()) {
+    for (auto it = handles->begin(); it != handles->end(); ++it) {


riversand963 · 2022-07-12T23:55:09Z

utilities/transactions/pessimistic_transaction_db.cc

+    const ColumnFamilyOptions& options,
+    const std::vector<std::string>& column_family_names,
+    std::vector<ColumnFamilyHandle*>* handles) {
+  InstrumentedMutexLock l(&column_family_mutex_);


I wonder if lock acquisition can be postponed after line 394, but we don't have to address this in this PR, given that CreateColumnFamily's behavior.

facebook-github-bot · 2022-07-14T00:51:13Z

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-07-19T00:28:43Z

@DaMatrix has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-07-19T00:30:18Z

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

riversand963

Thanks @DaMatrix for the fix.

riversand963 · 2022-07-19T00:37:28Z

Can you also update HISTORY.md to mention the bug fix?

riversand963 · 2022-07-19T01:12:20Z

utilities/transactions/transaction_test.cc

+  ASSERT_OK(db->CreateColumnFamilies(cf_options, cf_names, &cf_handles));
+  ASSERT_OK(db->Put(write_options, cf_handles[0], "foo", "bar"));
+  ASSERT_OK(db->DropColumnFamilies(cf_handles));
+}


Looks like you need to delete the cf_handles.

================================================================= ==2105374==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x698f67 in operator new(unsigned long) (/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/fbcode/buck-out/dev/gen/aab7ed39/internal_repo_rocksdb/repo/transaction_test+0x698f67) #1 0x7f663d74fe8c in rocksdb::DBImpl::CreateColumnFamilyImpl(rocksdb::ColumnFamilyOptions const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, rocksdb::ColumnFamilyHandle**) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2845 #2 0x7f663d7746ad in rocksdb::DBImpl::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2732 #3 0x7f663e120bf7 in rocksdb::PessimisticTransactionDB::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/utilities/transactions/pessimistic_transaction_db.cc:396 #4 0x579479 in rocksdb::TransactionTest_WriteWithBulkCreatedColumnFamilies_Test::TestBody() internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6511 #5 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2682:50 #6 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2672:6 #7 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2861:14 #8 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2833:6 #9 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:3015:31 #10 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2993:6 #11 0x7f663be07b1e in testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5855:47 #12 0x7f663be06d87 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2665:29 #13 0x7f663be06d87 in testing::UnitTest::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5438:55 #14 0x697de0 in RUN_ALL_TESTS() third-party-buck/platform010/build/googletest/include/gtest/gtest.h:2490 #15 0x697d7a in main internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6529 #16 0x7f663a103656 in __libc_start_call_main /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #17 0x7f663a103717 in __libc_start_main_impl /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../csu/libc-start.c:409:3 #18 0x3b4c40 in _start /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116 Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x698f67 in operator new(unsigned long) (/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/fbcode/buck-out/dev/gen/aab7ed39/internal_repo_rocksdb/repo/transaction_test+0x698f67) #1 0x7f663d74fe8c in rocksdb::DBImpl::CreateColumnFamilyImpl(rocksdb::ColumnFamilyOptions const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, rocksdb::ColumnFamilyHandle**) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2845 #2 0x7f663d7746ad in rocksdb::DBImpl::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2732 #3 0x7f663e120bf7 in rocksdb::PessimisticTransactionDB::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/utilities/transactions/pessimistic_transaction_db.cc:396 #4 0x579fbc in rocksdb::TransactionTest_WriteWithBulkCreatedColumnFamilies_Test::TestBody() internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6520 #5 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2682:50 #6 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2672:6 #7 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2861:14 #8 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2833:6 #9 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:3015:31 #10 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2993:6 #11 0x7f663be07b1e in testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5855:47 #12 0x7f663be06d87 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2665:29 #13 0x7f663be06d87 in testing::UnitTest::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5438:55 #14 0x697de0 in RUN_ALL_TESTS() third-party-buck/platform010/build/googletest/include/gtest/gtest.h:2490 #15 0x697d7a in main internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6529 #16 0x7f663a103656 in __libc_start_call_main /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #17 0x7f663a103717 in __libc_start_main_impl /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../csu/libc-start.c:409:3 #18 0x3b4c40 in _start /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116 Indirect leak of 8192 byte(s) in 1 object(s) allocated from: #0 0x7417da in posix_memalign (/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/fbcode/buck-out/dev/gen/aab7ed39/internal_repo_rocksdb/repo/transaction_test+0x7417da) #1 0x7f663e20968e in rocksdb::port::cacheline_aligned_alloc(unsigned long) internal_repo_rocksdb/repo/port/port_posix.cc:225 #2 0x7f663d086259 in rocksdb::Striped<rocksdb::port::Mutex, rocksdb::Slice>::Striped(unsigned long, std::function<unsigned long (rocksdb::Slice const&)>) internal_repo_rocksdb/repo/util/mutexlock.h:157 #3 0x7f663e3f2613 in rocksdb::TableCache::TableCache(rocksdb::ImmutableOptions const&, rocksdb::FileOptions const*, rocksdb::Cache*, rocksdb::BlockCacheTracer*, std::shared_ptr<rocksdb::IOTracer> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) internal_repo_rocksdb/repo/db/table_cache.cc:96 #4 0x7f663d480a8d in rocksdb::ColumnFamilyData::ColumnFamilyData(unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, rocksdb::Version*, rocksdb::Cache*, rocksdb::W ... ... ... s<char>, std::allocator<char> > const&, rocksdb::ColumnFamilyHandle**) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2820 #8 0x7f663d7746ad in rocksdb::DBImpl::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2732 #9 0x7f663e120bf7 in rocksdb::PessimisticTransactionDB::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/utilities/transactions/pessimistic_transaction_db.cc:396 #10 0x579fbc in rocksdb::TransactionTest_WriteWithBulkCreatedColumnFamilies_Test::TestBody() internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6520 #11 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2682:50 #12 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2672:6 #13 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2861:14 #14 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2833:6 #15 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:3015:31 #16 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2993:6 #17 0x7f663be07b1e in testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5855:47 #18 0x7f663be06d87 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2665:29 #19 0x7f663be06d87 in testing::UnitTest::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5438:55 #20 0x697de0 in RUN_ALL_TESTS() third-party-buck/platform010/build/googletest/include/gtest/gtest.h:2490 #21 0x697d7a in main internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6529 #22 0x7f663a103656 in __libc_start_call_main /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #23 0x7f663a103717 in __libc_start_main_impl /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../csu/libc-start.c:409:3 #24 0x3b4c40 in _start /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116 Indirect leak of 4 byte(s) in 1 object(s) allocated from: #0 0x698f67 in operator new(unsigned long) (/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/fbcode/buck-out/dev/gen/aab7ed39/internal_repo_rocksdb/repo/transaction_test+0x698f67) #1 0x7f663d47ff33 in rocksdb::ColumnFamilyData::ColumnFamilyData(unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, rocksdb::Version*, rocksdb::Cache*, rocksdb::WriteBufferManager*, rocksdb::ColumnFamilyOptions const&, rocksdb::ImmutableDBOptions const&, rocksdb::FileOptions const*, rocksdb::ColumnFamilySet*, rocksdb::BlockCacheTracer*, std::shared_ptr<rocksdb::IOTracer> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) internal_repo_rocksdb/repo/db/column_family.cc:542 #2 0x7f663d4bf189 in rocksdb::ColumnFamilySet::CreateColumnFamily(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int, rocksdb::Version*, rocksdb::ColumnFamilyOptions const&) internal_repo_rocksdb/repo/db/column_family.cc:1601 #3 0x7f663e5c06ea in rocksdb::VersionSet::CreateColumnFamily(rocksdb::ColumnFamilyOptions const&, rocksdb::VersionEdit const*) internal_repo_rocksdb/repo/db/version_set.cc:6092 #4 0x7f663e5b6dd8 in rocksdb::VersionSet::ProcessManifestWrites(std::deque<rocksdb::VersionSet::ManifestWriter, std::allocator<rocksdb::VersionSet::ManifestWriter> >&, rocksdb::InstrumentedMutex*, rocksdb::FSDirectory*, bool, rocksdb::ColumnFamilyOptions const*) internal_repo_rocksdb/repo/db/version_set.cc:4635 #5 0x7f663e5c3074 in rocksdb::VersionSet::LogAndApply(rocksdb::autovector<rocksdb::ColumnFamilyData*, 8ul> const&, rocksdb::autovector<rocksdb::MutableCFOptions const*, 8ul> const&, rocksdb::autovector<rocksdb::autovector<rocksdb::VersionEdit*, 8ul>, 8ul> const&, rocksdb::InstrumentedMutex*, rocksdb::FSDirectory*, bool, rocksdb::ColumnFamilyOptions const*, std::vector<std::function<void (rocksdb::Status const&)>, std::allocator<std::function<void (rocksdb::Status const&)> > > const&) internal_repo_rocksdb/repo/db/version_set.cc:4881 #6 0x7f663d55b0db in rocksdb::VersionSet::LogAndApply(rocksdb::ColumnFamilyData*, rocksdb::MutableCFOptions const&, rocksdb::VersionEdit*, rocksdb::InstrumentedMutex*, rocksdb::FSDirectory*, bool, rocksdb::ColumnFamilyOptions const*) internal_repo_rocksdb/repo/db/version_set.h:1099 #7 0x7f663d74f80c in rocksdb::DBImpl::CreateColumnFamilyImpl(rocksdb::ColumnFamilyOptions const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, rocksdb::ColumnFamilyHandle**) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2820 #8 0x7f663d7746ad in rocksdb::DBImpl::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/db/db_impl/db_impl.cc:2732 #9 0x7f663e120bf7 in rocksdb::PessimisticTransactionDB::CreateColumnFamilies(rocksdb::ColumnFamilyOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<rocksdb::ColumnFamilyHandle*, std::allocator<rocksdb::ColumnFamilyHandle*> >*) internal_repo_rocksdb/repo/utilities/transactions/pessimistic_transaction_db.cc:396 #10 0x579479 in rocksdb::TransactionTest_WriteWithBulkCreatedColumnFamilies_Test::TestBody() internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6511 #11 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2682:50 #12 0x7f663be06ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2672:6 #13 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2861:14 #14 0x7f663be06c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2833:6 #15 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:3015:31 #16 0x7f663be07321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2993:6 #17 0x7f663be07b1e in testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5855:47 #18 0x7f663be06d87 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2665:29 #19 0x7f663be06d87 in testing::UnitTest::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5438:55 #20 0x697de0 in RUN_ALL_TESTS() third-party-buck/platform010/build/googletest/include/gtest/gtest.h:2490 #21 0x697d7a in main internal_repo_rocksdb/repo/utilities/transactions/transaction_test.cc:6529 #22 0x7f663a103656 in __libc_start_call_main /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #23 0x7f663a103717 in __libc_start_main_impl /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../csu/libc-start.c:409:3 #24 0x3b4c40 in _start /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116 SUMMARY: AddressSanitizer: 117504 byte(s) leaked in 154 allocation(s).

Fix memory leak

facebook-github-bot · 2022-07-21T23:24:50Z

@DaMatrix has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-07-21T23:26:53Z

@DaMatrix has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-07-21T23:38:02Z

@DaMatrix has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-07-21T23:38:30Z

@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Correctly implement Create-/DropColumnFamilies for PessimisticTransac…

804a6b9

…tionDB

facebook-github-bot added the CLA Signed label Jul 10, 2022

riversand963 reviewed Jul 12, 2022

View reviewed changes

address review comments

9c9122b

riversand963 self-requested a review July 14, 2022 00:36

Merge branch 'main' into dev/fix-TransactionDB-CreateColumnFamilies

8c05534

riversand963 approved these changes Jul 19, 2022

View reviewed changes

riversand963 suggested changes Jul 19, 2022

View reviewed changes

Update transaction_test.cc

9a40b22

Fix memory leak

riversand963 approved these changes Jul 21, 2022

View reviewed changes

Update transaction_test.cc

d3ee9f0

Merge branch 'main' into dev/fix-TransactionDB-CreateColumnFamilies

d2102b4

facebook-github-bot closed this in 6bebe65 Jul 22, 2022

DaMatrix deleted the dev/fix-TransactionDB-CreateColumnFamilies branch July 23, 2022 11:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB #10332

Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB #10332

DaMatrix commented Jul 10, 2022

riversand963 left a comment

riversand963 Jul 12, 2022

riversand963 Jul 12, 2022

riversand963 Jul 12, 2022

riversand963 Jul 12, 2022

riversand963 Jul 12, 2022

facebook-github-bot commented Jul 14, 2022

facebook-github-bot commented Jul 19, 2022

facebook-github-bot commented Jul 19, 2022

riversand963 left a comment

riversand963 commented Jul 19, 2022

riversand963 Jul 19, 2022

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022

Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB #10332

Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB #10332

Conversation

DaMatrix commented Jul 10, 2022

riversand963 left a comment

Choose a reason for hiding this comment

riversand963 Jul 12, 2022

Choose a reason for hiding this comment

riversand963 Jul 12, 2022

Choose a reason for hiding this comment

riversand963 Jul 12, 2022

Choose a reason for hiding this comment

riversand963 Jul 12, 2022

Choose a reason for hiding this comment

riversand963 Jul 12, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Jul 14, 2022

facebook-github-bot commented Jul 19, 2022

facebook-github-bot commented Jul 19, 2022

riversand963 left a comment

Choose a reason for hiding this comment

riversand963 commented Jul 19, 2022

riversand963 Jul 19, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022

facebook-github-bot commented Jul 21, 2022