Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix underflow in FIFOCompactionPicker #10386

Closed
wants to merge 2 commits into from
Closed

Fix underflow in FIFOCompactionPicker #10386

wants to merge 2 commits into from

Conversation

lhsoft
Copy link
Contributor

@lhsoft lhsoft commented Jul 19, 2022 •
edited
Loading

Fix #10133

ajkr
ajkr approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

@riversand963 riversand963 riversand963 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIFO compaction may fail to clean up files based on TTL.
4 participants
@lhsoft @facebook-github-bot @ajkr @riversand963