Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sufficient subcompactions under round-robin compaction priority #10422

Closed
wants to merge 1 commit into from
Closed

Allow sufficient subcompactions under round-robin compaction priority #10422

wants to merge 1 commit into from

Conversation

littlepig2013
Copy link
Contributor

Summary:

Allow sufficient subcompactions can be used when the number of input files is less than max_subcompactions under round-robin compaction priority.

Test Case:
Add RoundRobinWithoutAdditionalResources into db_compaction_test

ajkr
ajkr approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

@littlepig2013 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littlepig2013 @facebook-github-bot @ajkr