Add new option num_file_reads_for_auto_readahead in BlockBasedTableOptions #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshamahajan15
force-pushed
the
opt_async_io
branch
2 times, most recently
from
a904831
to
df764be
Compare
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anand1976
approved these changes
Aug 26, 2022
| // change. | ||
| // | ||
| // Default: 2 | ||
| uint64_t num_file_reads_for_auto_readahead = 2; |
There was a problem hiding this comment.
Just for my clarification, is a value of 0 valid? If 0, the readahead will start on the very first read from the file?
There was a problem hiding this comment.
Yes! 0 mean start from the seek.
|
I will land it after landing #10602 because of dependency issues. |
…tions Summary: RocksDB does auto-readahead for iterators on noticing more than two reads for a table file if user doesn't provide readahead_size and reads are sequential. A new option num_file_reads_for_auto_readahead is added which can be configured and sets after how many sequential reads prefetching should be start. Test Plan: Existing and new unit test Reviewers: Subscribers: Tasks: Tags:
akankshamahajan15
force-pushed
the
opt_async_io
branch
from
df764be
to
a16f33e
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: RocksDB does auto-readahead for iterators on noticing more
than two reads for a table file if user doesn't provide readahead_size and reads are sequential.
A new option num_file_reads_for_auto_readahead is added which can be
configured and indicates after how many sequential reads prefetching should
be start.
Test Plan: Existing and new unit test
Reviewers:
Subscribers:
Tasks:
Tags: