Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForwardIterator: used newly added VersionStorageInfo::FindFileInRange #10592

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ForwardIterator: used newly added VersionStorageInfo::FindFileInRange #10592

wants to merge 2 commits into from

Conversation

rockeet
Copy link
Contributor

@rockeet rockeet commented Aug 28, 2022

  1. FindFileInRange is defined in version_set.cc, ForwardIterator should use it to reduce code explosion
  2. The only one FindFileInRange can be optimized some way
    • We have optimized FindFileInRange by devirtualization and prefix caching for known Comparator (now just BytewiseComparator and ReverseBytewiseComparator) with 30x+ speed up, if rocksdb likes this optimization, I'll create a PR.

@rockeet rockeet mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rockeet @facebook-github-bot