Make LocalTimeR fork safe by avoid calling localtime_r #10652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On multi process, when a thread forking a child process while another thread has entered mutex lock in __tz_convert, the newly forked process will deadlock when calling to localtime_r which call to __tz_convert.
rockeet
force-pushed
the
fix.localtime_r
branch
from
53d62bb
to
47a9982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On multi process, when a thread forking a child process while another thread has entered mutex lock in __tz_convert, the newly forked process will deadlock when calling to localtime_r which call to __tz_convert.