Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db.h: MultiGet: forward to more efficient overload #10664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rockeet
Copy link
Contributor

@rockeet rockeet commented Sep 13, 2022

Forward MultiGet to overload with single cf.

}
const bool sorted_input = false) {
std::string* timestamps = nullptr;
MultiGet(options, column_family, num_keys, keys, values, timestamps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overload, in turn, forwards to an overload that returns NotSupported (line 630).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overload, in turn, forwards to an overload that returns NotSupported (line 630).

That NotSupported is the default impl, derived DB classes have overrided that MultiGet overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants