Reset pessimistic transaction's read/commit timestamps during Initialize() #10677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ltamasi
approved these changes
Sep 14, 2022
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
Thanks @ltamasi for the review! |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocksDB allows reusing old
Transactionobjects when creating new ones. Therefore, we need toreset the transaction's read and commit timestamps back to default values
kMaxTxnTimestamp.Otherwise,
CommitAndTryCreateSnapshot()may fail with "Status::InvalidArgument("Different commit ts specified")".Test plan:
make check