move db_stress locking to StressTest::Test*() functions
#10678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
approved these changes
Sep 15, 2022
|
Thanks for the review! Yeah I ran each job once and there was no relevant failure. I checked some jobs to verify no deadlock but not all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One problem of the previous strategy was
NonBatchedOpsStressTest::TestIngestExternalFile()could release the lock forrand_keys[0]inrand_column_families[0], and then subsequent operations in the same loop iteration (e.g.,TestPut()) would run without locking. This PR changes the strategy so eachTest*()function is responsible for acquiring and releasing its own locks.