Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential memory leak in ArenaWrappedDBIter::Refresh() #10716

Closed
wants to merge 1 commit into from

Conversation

cbi42
Copy link
Member

@cbi42 cbi42 commented Sep 21, 2022

Summary: Fix potential memory leak in ArenaWrappedDBIter::Refresh() introduced in #10705. See #10705 (comment) for detail.

Test plan: make check

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cbi42 added a commit to cbi42/rocksdb that referenced this pull request Sep 21, 2022
…10716)

Summary:
Fix potential memory leak in ArenaWrappedDBIter::Refresh() introduced in facebook#10705. See facebook#10705 (comment) for detail.

Pull Request resolved: facebook#10716

Test Plan: make check

Reviewed By: ajkr

Differential Revision: D39698561

Pulled By: cbi42

fbshipit-source-id: dc0d0c6e3878eaa84f87623fbe4916b9b08b077a
riversand963 pushed a commit that referenced this pull request Sep 21, 2022
Summary:
Fix potential memory leak in ArenaWrappedDBIter::Refresh() introduced in #10705. See #10705 (comment) for detail.

Pull Request resolved: #10716

Test Plan: make check

Reviewed By: ajkr

Differential Revision: D39698561

Pulled By: cbi42

fbshipit-source-id: dc0d0c6e3878eaa84f87623fbe4916b9b08b077a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants