Small cleanup in NonBatchedOpsStressTest::VerifyDb #10740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Sep 26, 2022
| Get, | ||
| MultiGet, | ||
| GetMergeOperands, | ||
| NumberOfMethods |
There was a problem hiding this comment.
Nit: maybe add a note so that future developers will not accidentally any item below kNumberOfMethods.
Also, I think our naming convention prefers kIterator, etc.
There was a problem hiding this comment.
Will do. Thanks for the quick review @riversand963 !
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The PR cleans up the logic in
NonBatchedOpsStressTest::VerifyDbso thatthe verification method is picked using a single random number generation.
It also eliminates some repeated key comparisons and makes some small
code hygiene improvements.
Test Plan:
Ran a simple blackbox crash test.