Add OpenSSL to docker image #10741
Closed
Add OpenSSL to docker image #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jay-zhuang
reviewed
Sep 26, 2022
| @@ -16,6 +16,7 @@ RUN apt-get install -y libgflags-dev libtbb-dev | |||
| RUN apt-get install -y libsnappy-dev zlib1g-dev libbz2-dev liblz4-dev libzstd-dev | |||
| # install cmake | |||
| RUN apt-get install -y cmake | |||
| RUN apt-get install libssl-dev | |||
There was a problem hiding this comment.
Should it be:
Suggested change
| RUN apt-get install libssl-dev | |
| RUN apt-get install -y libssl-dev |
|
@anand1976 has updated the pull request. You must reimport the pull request before landing. |
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docker image with OpenSSL, required by the folly build.