db_stress TestIngestExternalFile avoid empty files #10754
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all the keys in range [key_base, shared->GetMaxKey()) are non-overwritable
TestIngestExternalFile()
would attempt to ingest a file with zero keys, leading to the following error: "Cannot create sst file with no entries". This PR changesTestIngestExternalFile()
to return early in that case instead of going through with the ingestion attempt.