Use kXXH3 as default checksum (CPU efficiency) #10778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since this has been supported for about a year, I think it's time to make it the default. This should improve CPU efficiency slightly on most hardware. A current performance comparison using buck build: ... Test Plan: make check, unit tests updated
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
romanz
added a commit
to romanz/rust-rocksdb
that referenced
this pull request
Mar 11, 2023
Following facebook/rocksdb#10778, this change will allow creating backward-compatible RocksDB tables (that can be read using old version of RocksDB, without XXH3 support).
romanz
added a commit
to romanz/rust-rocksdb
that referenced
this pull request
Mar 11, 2023
Following facebook/rocksdb#10778, this change will allow creating backward-compatible RocksDB tables (that can be read using older versions of RocksDB, without XXH3 support).
romanz
added a commit
to romanz/rust-rocksdb
that referenced
this pull request
Apr 14, 2023
Following facebook/rocksdb#10778, this change will allow creating backward-compatible RocksDB tables (that can be read using old version of RocksDB, without XXH3 support).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since this has been supported for about a year, I think it's time to make it the default. This should improve CPU efficiency slightly on most hardware.
A current DB performance comparison using buck+clang build:
kXXH3 (+0.2% DB write throughput):
fillseq [AVG 1000 runs] : 822149 (± 1004) ops/sec; 91.0 (± 0.1) MB/seckCRC32c:
fillseq [AVG 1000 runs] : 820484 (± 1203) ops/sec; 90.8 (± 0.1) MB/secMicro benchmark comparison:
Machine 1, buck+clang build:
xxh3 [AVG 20 runs] : 3358616 (± 19091) ops/sec; 13119.6 (± 74.6) MB/seccrc32c [AVG 20 runs] : 2578725 (± 7742) ops/sec; 10073.1 (± 30.2) MB/secMachine 2, make+gcc build, DEBUG_LEVEL=0 PORTABLE=0:
xxh3 [AVG 20 runs] : 6182084 (± 137223) ops/sec; 24148.8 (± 536.0) MB/seccrc32c [AVG 20 runs] : 5032465 (± 42454) ops/sec; 19658.1 (± 165.8) MB/secTest Plan: make check, unit tests updated