Verify columns in NonBatchedOpsStressTest::VerifyDb #10783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y deterministically
…y deterministically
…nBatchedOpsStressTest::TestPrefixScan; add TODOs
…tressTest::VerifyDb
This reverts commit aea07d4.
This reverts commit a049cb1.
This reverts commit 8db29ae.
…ixScan" This reverts commit 340e9cc.
This reverts commit 6426d98.
…ns in NonBatchedOpsStressTest::TestPrefixScan; add TODOs" This reverts commit 18be75d.
This reverts commit 4f1b3a8.
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As the first step of covering the wide-column functionality of iterators
in our stress tests, the patch adds verification logic to
NonBatchedOpsStressTest::VerifyDbthat checks whether theiterator's value and columns are in sync. Note: I plan to update the other
types of stress tests and add similar verification for prefix scans etc.
in separate PRs.
Test Plan:
Ran some simple blackbox crash tests.