Allow Flush(sync=true) not supported in DB::Open() and db_stress #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anand1976
approved these changes
Oct 6, 2022
hx235
force-pushed
the
stress_sync_wal_not_supported
branch
from
41a68fa
to
47d55d1
Compare
hx235
changed the title
hx235
force-pushed
the
stress_sync_wal_not_supported
branch
2 times, most recently
from
65d0af4
to
c4958a6
Compare
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@anand1976 Updated the DB::Open path and PR summary to reflect our offline discussion. |
hx235
changed the title
|
Update to main |
hx235
force-pushed
the
stress_sync_wal_not_supported
branch
from
c4958a6
to
c6370ba
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
reviewed
Oct 10, 2022
| @@ -836,7 +836,7 @@ void StressTest::OperateDb(ThreadState* thread) { | |||
| if (thread->rand.OneInOpt(FLAGS_manual_wal_flush_one_in)) { | |||
| bool sync = thread->rand.OneIn(2) ? true : false; | |||
| Status s = db_->FlushWAL(sync); | |||
| if (!s.ok()) { | |||
| if (!s.ok() && !(sync && s.IsNotSupported())) { | |||
There was a problem hiding this comment.
The below SyncWAL() appears susceptible to the same problem. Maybe let WS disable these features in their config until they complete support for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#10698 made
Flush(sync=true)required forDB::Open()(to pass the original but now deleted assertionimpl->TEST_WALBufferIsEmpty()undermanual_wal_flush=true, see #10698 summary for more ) as well as db_stress to pass.However RocksDB users may not implement SyncWAL() (used inFlush(sync=true)). Therefore we replace such in DB::Open and db_stress in this PR and align with https://github.com/facebook/rocksdb/blob/main/db/db_impl/db_impl_open.cc#L1883-L1887 and https://github.com/facebook/rocksdb/blob/main/db_stress_tool/db_stress_test_base.cc#L847-L849
Test:
make check