Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken dependency: update zlib from 1.2.12 to 1.2.13 #10833

Closed
wants to merge 3 commits into from

Conversation

xiaochenfan
Copy link
Contributor

@xiaochenfan xiaochenfan commented Oct 19, 2022

zlib(https://zlib.net/) has released v1.2.13.

1.2.12 is no longer available for downloading and Makefile for rocksdb will be broken due to can't find the source .tar.gz.

https://nvd.nist.gov/vuln/detail/CVE-2022-37434

This pr update the version number and the shasum of new .tar.gz file. (1.2.13)

Fixes #10876

@adamretter
Copy link
Collaborator

LGTM :-) @jay-zhuang can you merge it please?

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@adamretter
Copy link
Collaborator

@siying I believe this is also dependent on @jay-zhuang uploading the latest zlib binary to the rocksdb S3 bucket - hence the CI failures.

@facebook-github-bot
Copy link
Contributor

@xiaochenfan has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@xiaochenfan has updated the pull request. You must reimport the pull request before landing.

@adamretter
Copy link
Collaborator

@xiaochenfan Can we get this merged ASAP to main and also 7.8.fb please, as it prevents people from being able to build?

@facebook-github-bot
Copy link
Contributor

@xiaochenfan has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded. LGTM

chetangudisagar added a commit to CorfuDB/CorfuDB that referenced this pull request Feb 28, 2023
xnull pushed a commit to CorfuDB/CorfuDB that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zlib 1.2.12 url in Makefile not available anymore
4 participants