Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HyperClockCache Rollback bug in #10801 #10843

Closed
wants to merge 3 commits into from
Closed

Fix HyperClockCache Rollback bug in #10801 #10843

wants to merge 3 commits into from

Commits on Oct 21, 2022

  1. Fix HyperClockCache Rollback buug in facebook#10801 

    Summary: There were some cases where we saved a reference to the hash
value instead of saving the hash value itself. This fixes by generally
doing Rollback as soon as an entry is no longer visible to Lookups,
so we don't need to copy the value for later passing to Rollback.

Test Plan: watch for clean crash test, TSAN
    @pdillinger
    pdillinger committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    acd74af View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into hyperclock_rollback_fix

    @pdillinger
    pdillinger committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e8c286c View commit details
    Browse the repository at this point in the history

  3. Alternate fix

    @pdillinger
    pdillinger committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    1f03f0f View commit details
    Browse the repository at this point in the history