Avoid repeat periodic stats printing when there is no change #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When there is a column family that doesn't get any traffic, its stats are still dumped when options.options.stats_dump_period_sec triggers. This sometimes spam the information logs. With this change, we skip the printing if there is not change, until 8 periods. Test Plan: Manually test the behavior with hacked db_bench setups.
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jay-zhuang
approved these changes
Oct 27, 2022
db/internal_stats.cc
Outdated
Comment on lines
1070
to
1078
| } | ||
| if (no_cf_change_period_since_dump_++ > 0) { | ||
| // Not ready to sync | ||
| if (no_cf_change_period_since_dump_ == kMaxNoChangePeriodSinceDump) { | ||
| // Next periodic, we need to dump stats even if there is no change. | ||
| no_cf_change_period_since_dump_ = 0; | ||
| } | ||
| return true; | ||
| } |
There was a problem hiding this comment.
nit:
Suggested change
| } | |
| if (no_cf_change_period_since_dump_++ > 0) { | |
| // Not ready to sync | |
| if (no_cf_change_period_since_dump_ == kMaxNoChangePeriodSinceDump) { | |
| // Next periodic, we need to dump stats even if there is no change. | |
| no_cf_change_period_since_dump_ = 0; | |
| } | |
| return true; | |
| } | |
| } else { | |
| no_cf_change_period_since_dump_++; | |
| } | |
| if (!has_change && no_cf_change_period_since_dump_ < kMaxNoChangePeriodSinceDump) { | |
| return true; | |
| } |
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When there is a column family that doesn't get any traffic, its stats are still dumped when options.options.stats_dump_period_sec triggers. This sometimes spam the information logs. With this change, we skip the printing if there is not change, until 8 periods.
Test Plan: Manually test the behavior with hacked db_bench setups.