Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenBSD/arm64 support for detection of CRC32 and PMULL #10902

Closed
wants to merge 1 commit into from

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Oct 29, 2022

No description provided.

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change assumes non-__APPLE__ implies __OpenBSD__, __FreeBSD__, or __linux__. I may need a reference for that, or the assumption could be removed by addressing the comments on the code.

util/crc32c_arm64.cc Show resolved Hide resolved
util/crc32c_arm64.cc Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@brad0 has updated the pull request. You must reimport the pull request before landing.

@brad0
Copy link
Contributor Author

brad0 commented Oct 31, 2022

The change assumes non-__APPLE__ implies __OpenBSD__, __FreeBSD__, or __linux__. I may need a reference for that, or the assumption could be removed by addressing the comments on the code.

Well originally I had non-APPLE being Linux and FreeBSD. But I changed it to where getauxval() is detected and FreeBSD.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants