Minimal RocksJava compliance with Java 8 language level (EB 1046) #10951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpaxton
force-pushed
the
eb-1046-java8-minimal-fix
branch
2 times, most recently
from
60aafa4
to
ef5bfe7
Compare
alanpaxton
force-pushed
the
eb-1046-java8-minimal-fix
branch
from
be03f03
to
c89d9f6
Compare
|
Hi @jay-zhuang you were good enough to review a previous PR in this area which I've had to abandon because I had missed that it hadn't got to the merge point; it changed a lot of files and I wasn't confident enough of the rebase, so I started again with reduced scope to get some improvements suggested by Java8 inspections incorporated. Thanks. |
alanpaxton
force-pushed
the
eb-1046-java8-minimal-fix
branch
from
c89d9f6
to
97ea335
Compare
alanpaxton
force-pushed
the
eb-1046-java8-minimal-fix
branch
5 times, most recently
from
457d8ba
to
05c35e1
Compare
use java 8 flags in build add final on params and variables fix modifier order where wrong <p> in comment blank lines use enhanced for loop where applicable
( add final on params and variables fix modifier order where wrong <p> in comment blank lines use enhanced for loop where applicable
try-with-resources, ignored variable names.
Method was removed after current branch commenced. Somehow (badly managed rebase by me ?) it got added back. Manually remove it again.
alanpaxton
force-pushed
the
eb-1046-java8-minimal-fix
branch
from
4f077e2
to
dc48838
Compare
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alanpaxton has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a small (and automatic) set of IntelliJ Java inspections/repairs to the Java interface to RocksDB Java and its tests.
Partly enabled by the fact that we now (from RocksDB7) require java 8.
Explicit
in empty lines in javadoc comments.
Parameters and variables made final where possible.
Anonymous subclasses converted lambdas.
Some tests which previously used other assertion models were converted to assertj, e.g. (assertThat(actual).isEqualTo(expected)
In a very few cases tests were found to be inoperative or broken, and were repaired. No problems with actual RocksDB behaviour were observed.
This PR is intended to replace #9618 - that PR was not merged, and attempts to rebase it have yielded a questionable looking diff, so we choose to go back to square 1 here, and implement a conservative set of changes.