Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace sprintf with its safe version snprintf (v2) #11011

Closed
wants to merge 1 commit into from
Closed

replace sprintf with its safe version snprintf (v2) #11011

wants to merge 1 commit into from

Conversation

arvid220u
Copy link
Contributor

same motivations as #5475, applied to the last remaining sprintf.

@facebook-github-bot
Copy link
Contributor

Hi @arvid220u!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ajkr ajkr changed the title replace sprintf with its safe version sprintf (v2) replace sprintf with its safe version snprintf (v2) Dec 2, 2022
ajkr
ajkr approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 00238a3.

Qiaolin-Yu pushed a commit to asu-idi/rocksdb_block_cache_tracing that referenced this pull request Jan 30, 2023
@arvid220u @Qiaolin-Yu
replace sprintf with its safe version snprintf (v2) (#11011)
cd6bd93 
Summary:
same motivations as facebook/rocksdb#5475, applied to the last remaining `sprintf`.

Pull Request resolved: facebook/rocksdb#11011

Reviewed By: pdillinger

Differential Revision: D41673500

Pulled By: ajkr

fbshipit-source-id: 88618ea791cafad86a9a491799c45979d46e3544
@igorcanadi igorcanadi mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arvid220u @facebook-github-bot @ajkr