Add back Options::CompactionOptionsFIFO::allow_compaction to stress/crash test #11063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
#10777 was reverted (#10999) due to internal blocker and replaced with a better fix #10922. However, the revert also reverted the
Options::CompactionOptionsFIFO::allow_compaction
stress/crash coverage added by the PR.It's an useful coverage cuz setting
Options::CompactionOptionsFIFO::allow_compaction=true
will increase the compaction score of L0 files for FIFO and then trigger more FIFO compaction. This speed up discovery of bug related to FIFO compaction like #10955. To see the speedup, compare the failure occurrence in following commands withOptions::CompactionOptionsFIFO::allow_compaction=true/false
Therefore this PR is adding it back to stress/crash test.
Test:
Rehearsal stress test to make sure stress/crash test is stable