Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate SstFileWriter range tombstones cover positive ranges #11322

Closed
wants to merge 1 commit into from
Closed

validate SstFileWriter range tombstones cover positive ranges #11322

wants to merge 1 commit into from

Conversation

ajkr
Copy link
Contributor

@ajkr ajkr commented Mar 22, 2023

As titled. This is the same as #6788 but for range tombstones written through SstFileWriter rather than through DB.

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ajkr ajkr requested a review from cbi42 March 22, 2023 22:47
cbi42
cbi42 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@cbi42 cbi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajkr
Copy link
Contributor Author

ajkr commented Mar 23, 2023

Thanks for the review!

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 9f8cdc8.

@ajkr ajkr mentioned this pull request Apr 20, 2023
Closed
@igorcanadi igorcanadi mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbi42 cbi42 cbi42 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajkr @facebook-github-bot @cbi42