Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to trigger flush when the number of range deletions reach a threshold #11358

Closed
wants to merge 16 commits into from
Closed

Add an option to trigger flush when the number of range deletions reach a threshold #11358

wants to merge 16 commits into from

Commits on Jul 31, 2023

  1. Improve performance the mix of range-delete and read workloads. 

    The idea is to force flush after few range-delete operations.
Experimentation shows 32 or 64 giving good performance.

memtable_max_range_deletions is available as a ColumnFamilyOption.
The default is 0, which disables. it.
    @vrdhn @cbi42
    vrdhn authored and cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e2352bc View commit details
    Browse the repository at this point in the history

  2. Update option comment.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fe6b11e View commit details
    Browse the repository at this point in the history

  3. Count range tombstones whether concurrent update or not.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f0fef7a View commit details
    Browse the repository at this point in the history

  4. Make option mutable.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e828729 View commit details
    Browse the repository at this point in the history

  5. Log num_range_deletes.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    91de341 View commit details
    Browse the repository at this point in the history

  6. Fix option logging indent.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    bddc35c View commit details
    Browse the repository at this point in the history

  7. Add TODO for correct flush_reson.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    64b7ee2 View commit details
    Browse the repository at this point in the history

  8. Correct num_range_deletes counting.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    36b83bf View commit details
    Browse the repository at this point in the history

  9. Add unit test.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9c03ad0 View commit details
    Browse the repository at this point in the history

  10. Add change log.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d0628f9 View commit details
    Browse the repository at this point in the history

  11. Add cast.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    88ed110 View commit details
    Browse the repository at this point in the history

  12. Remove flag memtable_max_range_deletions_reached_.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e59a4d2 View commit details
    Browse the repository at this point in the history

  13. Update num_range_delets_ correctly.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4135a99 View commit details
    Browse the repository at this point in the history

  14. Enable option in crash test.

    @cbi42
    cbi42 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    bdfe899 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fix Java API comment.

    @cbi42
    cbi42 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8663e79 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Merge branch 'main' into vrdhn-upstream-range-del-read

    @cbi42
    cbi42 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2629a8c View commit details
    Browse the repository at this point in the history