Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when an SST file in MANIFEST is not found #11573

Closed
wants to merge 3 commits into from

Conversation

cbi42
Copy link
Member

@cbi42 cbi42 commented Jun 28, 2023

Summary: I got the following error message when an SST file is recorded in MANIFEST but is missing from the db folder.
It's confusing in two ways:

  1. The part about file "./074837.ldb" which RocksDB will attempt to open only after ./074837.sst is not found.
  2. The last part about "No such file or directory in file ./MANIFEST-074507" sounds like 074837.ldb is not found in manifest.
ldb --hex --db=. get some_key

Failed: Corruption: Corruption: IO error: No such file or directory: While open a file for random read: ./074837.ldb: No such file or directory in file ./MANIFEST-074507

Improving the error message a little bit:

Test plan: run the same command after this PR

Failed: Corruption: Corruption: IO error: No such file or directory: While open a file for random read: ./074837.sst: No such file or directory  The file ./MANIFEST-074507 may be corrupted.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will save me some recurring explaining effort

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cbi42
Copy link
Member Author

cbi42 commented Jul 5, 2023

Thanks for the review! Seems I forgot to import this one.

@facebook-github-bot
Copy link
Contributor

@cbi42 merged this pull request in 854eb76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants