Fix a unit test hole for recovering UDTs with WAL files #11577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlyzhang
force-pushed
the
test_ts_recovery
branch
from
1292fcf
to
b8b24b5
Compare
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jowlyzhang
force-pushed
the
test_ts_recovery
branch
from
b8b24b5
to
27ceb99
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
|
Don't forget to re-import :) |
jowlyzhang
force-pushed
the
test_ts_recovery
branch
from
27ceb99
to
535f0a0
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
Thank you for your help reviewing this PR and the reminder! |
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jowlyzhang merged this pull request in baf37a0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @pdillinger for pointing out this test hole. The test
DBWALTestWithTimestamp.Recoverthat is intended to test recovery from WAL including user-defined timestamps doesn't achieve its promised coverage. Specifically, after #11557, timestamps will be removed during flush, and RocksDB by default flush memtables during recovery withavoid_flush_during_recoverydefaults to false. This test didn't fail even if all the timestamps are quickly lost due to the default flush behavior.This PR renamed test
RecovertoRecoverAndNoFlush, and updated it to verify timestamps are successfully recovered from WAL with some time-travel reads.avoid_flush_during_recoveryis set to true to help do this verification.On the other hand, for test
DBWALTestWithTimestamp.RecoverAndFlush, since flush on reopen is DB's default behavior. Setting the flagsmax_write_bufferandarena_block_sizeare not really the factors that enforces the flush, so these flags are removed.Test Plan:
./db_wal_test