Make rocksdb_options_add_compact_on_deletion_collector_factory backward compatible
#11593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
approved these changes
Jul 7, 2023
| @@ -14,7 +14,7 @@ | |||
| * Add `WriteBatch::Release()` that releases the batch's serialized data to the caller. | |||
|
|
|||
| ### Public API Changes | |||
| * Add parameter `deletion_ratio` to C API `rocksdb_options_add_compact_on_deletion_collector_factory`. | |||
| * Add C API `rocksdb_options_add_compact_on_deletion_collector_factory_del_ratio`. | |||
There was a problem hiding this comment.
Added comments regarding change log. Rest LGTM. Thanks for the quick fix.
There was a problem hiding this comment.
I think it should be added as a separate entry as mentioning backward compatibility as we have already cut the branch.
There was a problem hiding this comment.
Thanks, updated the change log.
Edit: decided not to add a separate entry as discussed offline.
|
@cbi42 has updated the pull request. You must reimport the pull request before landing. |
cbi42
force-pushed
the
c-api-backward-compatible
branch
from
7de2aa6
to
c3b093d
Compare
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
pushed a commit
that referenced
this pull request
Jul 9, 2023
…ward compatible (#11593) Summary: #11542 added a parameter to the C API `rocksdb_options_add_compact_on_deletion_collector_factory` which causes some internal builds to fail. External users using this API would also require code change. Making the API backward compatible by restoring the old C API and add the parameter to a new C API `rocksdb_options_add_compact_on_deletion_collector_factory_del_ratio`. Also updated change log for 8.4 and will backport this change to 8.4 branch once landed. Pull Request resolved: #11593 Test Plan: `make c_test && ./c_test` Reviewed By: akankshamahajan15 Differential Revision: D47299555 Pulled By: cbi42 fbshipit-source-id: 517dc093ef4cf02cac2fe4af4f1af13754bbda63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11542 added a parameter to the C API
rocksdb_options_add_compact_on_deletion_collector_factorywhich causes some internal builds to fail. External users using this API would also require code change. Making the API backward compatible by restoring the old C API and add the parameter to a new C APIrocksdb_options_add_compact_on_deletion_collector_factory_del_ratio.Also updated change log for 8.4 and will backport this change to 8.4 branch once landed.
Test plan:
make c_test && ./c_test