Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized code #11614

Closed
wants to merge 1 commit into from
Closed

optimized code #11614

wants to merge 1 commit into from

Conversation

szza
Copy link
Contributor

@szza szza commented Jul 14, 2023

improvement code by std::move and c++17

Signed-off-by: shuzz <shuzz@shuyilink.com>
Copy link
Contributor

@jowlyzhang jowlyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

@facebook-github-bot
Copy link
Contributor

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jowlyzhang merged this pull request in 2f71223.

rockeet pushed a commit to topling/toplingdb that referenced this pull request Dec 18, 2023
Summary:
improvement code by std::move and c++17

Pull Request resolved: facebook/rocksdb#11614

Reviewed By: ajkr

Differential Revision: D47599519

Pulled By: jowlyzhang

fbshipit-source-id: 6b897876f4e87e94a74c53d8db2a01303d500bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants