-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign function interface (Panama) blog #11760
Conversation
Is there a reason that the Java code does not use the C-interface of RocksDB (rather than the C++ one)? This FFI appears to be heading in that manner, but this would lead to a more standard means of accessing RocksDB functionality in non-C++ languages. |
Hi @mrambacher For my convenience I just built a wrapper around the C++ which I am familiar with, but you are of course right, FFI means we can easily wrap any C interface into Java, and the way forward for the future should be for RocksDB (however you define it) to maintain that single C interface, and just make sure it supports the features we need from Java, and any other client language that might be needed (Go and Rust spring to mind) |
85d9803
to
bacf35a
Compare
@anand1976 rebased and once again ready for review/import. |
bacf35a
to
6a99051
Compare
6a99051
to
1dd28d4
Compare
1dd28d4
to
a3be710
Compare
a3be710
to
dc70aa3
Compare
dc70aa3
to
45d2bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Report on experiments with project Panama Supporting graph files
45d2bcc
to
097f94d
Compare
@alanpaxton has updated the pull request. You must reimport the pull request before landing. |
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
We did some experimental work with FFI and native memory as a potential improvement to the Java API.
The work lives (unmerged) in #11095
This is the report text from that branch, extract as a blog post.
Along with some supporting files (png, pdf of graphs).