-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add write_buffer_manager setter into options and tests in c bindings, #12007
add write_buffer_manager setter into options and tests in c bindings, #12007
Conversation
51f5a86
to
46f47dd
Compare
6f3d2df
to
8dfc528
Compare
@ajkr could you take a look ? |
Since there are two (also #11710), I'll take the first one - also it allows constructing WBM without a cache object, which is convenient. But 11710 is missing test cases, so if you want to adapt this PR to add the test case, and any APIs that are missing from 11710, I would be happy to merge this too |
I cannot push on the other fork branch, nor fork again since I already have this fork, |
Yes, I think waiting for the other PR to be merged will be the simplest way. Let me try to expedite merging that one. Thanks for your willingness to contribute the test. |
82ed6ee
to
bc28771
Compare
bc28771
to
0773b3c
Compare
I've updated the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@benoitmeriaux has updated the pull request. You must reimport the pull request before landing. |
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@ajkr do you know when the next release is planned ? |
This will be in version 8.9, which should be tagged some time in December. |
following #11710
DBOptions