Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NewMultiCfIterator API #12153

Closed
wants to merge 23 commits into from
Closed

Introduce NewMultiCfIterator API #12153

wants to merge 23 commits into from

Commits on Mar 4, 2024

  1. MultiCfIterator Implementation - SeekToFirst() and Next() only

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1a5301c View commit details
    Browse the repository at this point in the history

  2. Take key comparator from users explicitly (with default set as Bytewi… 

    …seComparator)
    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ef13ec9 View commit details
    Browse the repository at this point in the history

  3. Add NewEmptyMultiColumnFamilyIterator and NewErrorMultiColumnFamilyIt… 

    …erator
    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    571cc82 View commit details
    Browse the repository at this point in the history

  4. Remove util/heap.h dependency

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e326537 View commit details
    Browse the repository at this point in the history

  5. attempt to fix linter

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    306712f View commit details
    Browse the repository at this point in the history

  6. Rebase and merge

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    59f14f7 View commit details
    Browse the repository at this point in the history

  7. Revise comment to include wide columns handling

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    cc072e5 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary externs

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0cdd17b View commit details
    Browse the repository at this point in the history

  9. Improve Next() algorithm

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    452cc5c View commit details
    Browse the repository at this point in the history

  10. Add check status

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6f2b8ec View commit details
    Browse the repository at this point in the history

  11. Use unique_ptr instead of raw pointer in the API

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    52af201 View commit details
    Browse the repository at this point in the history

  12. Use the comparator from the first cf and make sure it matches compara… 

    …tors in all other cfs
    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    978043d View commit details
    Browse the repository at this point in the history

  13. multi_cf_iterator->columns() implementation with the same invariant a… 

    …s value()
    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6b8d06d View commit details
    Browse the repository at this point in the history

  14. fix mingw build + other minor fixes

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    868239b View commit details
    Browse the repository at this point in the history

  15. linter fix

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    341af76 View commit details
    Browse the repository at this point in the history

  16. Rebase and remove unnecessary include

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c074aaf View commit details
    Browse the repository at this point in the history

  17. Fix linter and rebase

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5a852d9 View commit details
    Browse the repository at this point in the history

  18. Address feedback

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f160b4e View commit details
    Browse the repository at this point in the history

  19. Make MultiCFIter not valid for only one CF

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    de2f338 View commit details
    Browse the repository at this point in the history

  20. Use the generic iterator interface instead of multi_cf_iterator for u… 

    …nified experience
    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    d221bf3 View commit details
    Browse the repository at this point in the history

  21. rename MultiCfIteratorImpl to MultiCfIterator

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8a22393 View commit details
    Browse the repository at this point in the history

  22. remove unused include

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c8b5805 View commit details
    Browse the repository at this point in the history

  23. remove attribute_groups() api for now

    @jaykorean
    jaykorean committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3a42a58 View commit details
    Browse the repository at this point in the history