Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GitHub Actions jobs on forks #12191

Closed
wants to merge 1 commit into from

Conversation

pdillinger
Copy link
Contributor

@pdillinger pdillinger commented Dec 29, 2023

Summary: See new comment in pr-jobs.yml for context. I tried avoiding the massive copy-paste through some trial and error in #12156, but was unsuccessful.

Also upgrading actions/setup-python to v5 to fix a warning.

Test Plan:
Here's an example of a bad run from my fork, prior to this change:
https://github.com/pdillinger/rocksdb/actions/runs/7303363126
Here's the "skipped" run associated with this change on my fork:
https://github.com/pdillinger/rocksdb/actions/runs/7352251207
Here's the actual run associated with this PR:
https://github.com/facebook/rocksdb/actions/runs/7352262420

Summary: See new comment in pr-jobs.yml for context. I tried avoiding the
massive copy-paste through some trial and error in facebook#12156, but was
unsuccessful.

Also upgrading actions/setup-python to v5 to fix a warning.

Test Plan: TODO insert links to CI runs
@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@pdillinger merged this pull request in 5a1fb5c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants