Add more public APIs to crash test #12617
Conversation
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
changed the title
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
hx235
changed the title
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| std::unique_ptr<TransactionLogIterator> iter; | ||
| Status s = db_->GetUpdatesSince(seq, &iter); |
There was a problem hiding this comment.
Doesn't the user have to set some option for this to return results that make sense?
There was a problem hiding this comment.
Yeah - the wal_xxx parameters ned to be set very high. Still it was a bit flaky in my local run. Let me try again and add TestGetUpdatesSince in another PR for easier testing.
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Seeing way too many errors likely related to PromoteL0 from facebook#12617, containing ``` Cannot delete table file #N from level 0 since it is on level X ``` Test Plan: watch crash test results
Summary: Seeing way too many errors likely related to PromoteL0 from #12617, containing ``` Cannot delete table file #N from level 0 since it is on level X ``` Pull Request resolved: #12651 Test Plan: watch crash test results Reviewed By: hx235 Differential Revision: D57286208 Pulled By: pdillinger fbshipit-source-id: f7f0560cc0804ca297373c8d20ebc34986cc19d0
Context/Summary:
As titled. Bonus: found that PromoteL0 called with other concurrent PromoteL0 will return non-okay error so clarify the API.
Test:
CI