Fix c++ compilation errors on Linux using g++ #12685
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of compilation errors seen compiling on Linux (Ubuntu 22.04.4 LTS) using cmake 3.29 and g++ 11.4.0
Sampling of errors fixed are as follows:
NOTES:
cache/compressed_secondary_cache.cc - UncompressedData already takes in a const char*, so no need to cast to (char *)
const_cast is used to remove const qualifiers.
static_cast is used to change types (largely from one pointer type to another).
reinterpret_castwas used in places that static_cast would not work.