Fix the names of function objects added in PR 12681 #12689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57676418 |
Summary: These should be in `snake_case` (not `camelCase`) per our style guide. Differential Revision: D57676418
|
This pull request was exported from Phabricator. Differential Revision: D57676418 |
|
This pull request has been merged in 014368f. |
konstantinvilin
pushed a commit
to konstantinvilin/rocksdb
that referenced
this pull request
May 28, 2024
Summary: Pull Request resolved: facebook#12689 These should be in `snake_case` (not `camelCase`) per our style guide. Reviewed By: jowlyzhang Differential Revision: D57676418 fbshipit-source-id: 82ad6a87d1540f0b29c2f864ca0128287fe95a9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These should be in
snake_case(notcamelCase) per our style guide.Differential Revision: D57676418