Add avoid_flush_during_shutdown DB option #1451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @benrnd |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yiwu-arbug
force-pushed
the
unpersistent
branch
from
aa60cbf
to
47da936
Compare
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
ajkr
reviewed
Nov 1, 2016
| ### Public API Change | ||
|
|
||
| ### New Features | ||
| * Add avoid_flush_during_shutdown option, which speeds up DB shutdown by not flushing unpersisted data. Use it only when data loss is acceptable. The options is dynamically changeable. |
There was a problem hiding this comment.
if WAL is enabled, shouldn't there be no data loss?
yiwu-arbug
force-pushed
the
unpersistent
branch
from
47da936
to
aeee7d5
Compare
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
yiwu-arbug
force-pushed
the
unpersistent
branch
from
aeee7d5
to
f75bb19
Compare
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
|
Comment updated. @ajkr any more comments? |
Summary: Add avoid_flush_during_shutdown DB option. Test Plan: See the new unit test.
yiwu-arbug
force-pushed
the
unpersistent
branch
from
f75bb19
to
95c1380
Compare
|
Rebase. |
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
siying
approved these changes
Nov 2, 2016
|
Approved. Please merge after all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add avoid_flush_during_shutdown DB option.
Test Plan:
See the new unit test.