Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteRange user iterator support #1464

Closed
wants to merge 1 commit into from
Closed

DeleteRange user iterator support #1464

wants to merge 1 commit into from

Conversation

ajkr
Copy link
Contributor

@ajkr ajkr commented Nov 4, 2016 •
edited
Loading

Summary:

Note: reviewed in https://reviews.facebook.net/D65115

  • DBIter maintains a range tombstone accumulator. We don't cleanup obsolete tombstones yet, so if the user seeks back and forth, the same tombstones would be added to the accumulator multiple times.
  • DBImpl::NewInternalIterator() (used to make DBIter's underlying iterator) adds memtable/L0 range tombstones, L1+ range tombstones are added on-demand during NewSecondaryIterator() (see D62205)
  • DBIter uses ShouldDelete() when advancing to check whether keys are covered by range tombstones

Test Plan:

new end-to-end tests (https://reviews.facebook.net/D63927)

@ajkr
DeleteRange user iterator
53b2c91 
Summary:

Test Plan:

Reviewers:

Subscribers:
@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajkr @facebook-github-bot