Fail BackupEngine::Open upon meta-file read error #1654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
IslamAbdelRahman
approved these changes
Dec 14, 2016
| Log(options_.info_log, "Backup %u corrupted -- %s", backup.first, | ||
| s.ToString().c_str()); | ||
| corrupt_backups_.insert(std::make_pair( | ||
| backup.first, std::make_pair(s, std::move(backup.second)))); | ||
| } else if (!s.ok()) { | ||
| return s; |
There was a problem hiding this comment.
can we add a comment similar to the description of this PR here ?
|
@ajkr updated the pull request - view changes - changes since last import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to treat any failure to read a backup's meta-file as if the backup were corrupted; however, we should distinguish corruption errors from errors in the backup Env. This fixes an issue where callers would get inconsistent results from GetBackupInfo() if they called it on an engine that encountered Env error during initialization. Now we fail Initialize() in this case so callers cannot invoke GetBackupInfo() on such engines.