compaction_style and compaction_pri should output their value as a st… #1817
Conversation
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
util/options_helper.h
Outdated
| @@ -688,6 +688,18 @@ static std::unordered_map<std::string, CompactionStyle> | |||
| {"kCompactionStyleFIFO", kCompactionStyleFIFO}, | |||
| {"kCompactionStyleNone", kCompactionStyleNone}}; | |||
|
|
|||
| static std::unordered_map<char, std::string> compaction_style_logging_map = { | |||
There was a problem hiding this comment.
let's change char to CompactionStyle
There was a problem hiding this comment.
Can we use a name like compaction_style_to_string
There was a problem hiding this comment.
unordered_map does not support enum as a key well. Unless we have something like: (http://stackoverflow.com/questions/18837857/cant-use-enum-class-as-unordered-map-key). Is that what we want?
There was a problem hiding this comment.
can we use std::map ?
There was a problem hiding this comment.
sure, given the size is small :D
util/options_helper.h
Outdated
| @@ -688,6 +688,18 @@ static std::unordered_map<std::string, CompactionStyle> | |||
| {"kCompactionStyleFIFO", kCompactionStyleFIFO}, | |||
| {"kCompactionStyleNone", kCompactionStyleNone}}; | |||
|
|
|||
| static std::unordered_map<char, std::string> compaction_style_logging_map = { | |||
| {kCompactionStyleLevel, "level"}, | |||
There was a problem hiding this comment.
let's use the exact name of the enum as the string when logging
kCompactionStyleLevel instead of level
and so one
util/options_helper.h
Outdated
| {kCompactionStyleFIFO, "fifo"}, | ||
| {kCompactionStyleNone, "none"}}; | ||
|
|
||
| static std::unordered_map<char, std::string> compaction_pri_logging_map = { |
util/options_helper.h
Outdated
| {kCompactionStyleNone, "none"}}; | ||
|
|
||
| static std::unordered_map<char, std::string> compaction_pri_logging_map = { | ||
| {kByCompensatedSize, "by compensated size"}, |
There was a problem hiding this comment.
same kByCompensatedSize instead of by compensated size
|
@highker updated the pull request - view changes - changes since last import |
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
LGTM, but looks like there is an issue in importing the diff |
|
Command 'cd '/data/sandcastle/boxes/instance-rocksdb-int-git-convert-pull-request-to-internal-diff' && GIT_COMMITTER_EMAIL=svcscm@fb.com GIT_COMMITTER_NAME='Service User' git commit --amend '--author=svcscm' '-m' 'temporary commit'' failed with exit code stderr: Did I miss some config? |
|
@highker, can you please rebase your changes ? |
|
@highker updated the pull request - view changes - changes since last import |
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@highker updated the pull request - view changes - changes since last import |
|
@highker updated the pull request - view changes - changes since last import |
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@highker updated the pull request - view changes - changes since last import |
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@highker updated the pull request - view changes - changes since last import |
|
@highker updated the pull request - view changes - changes since last import |
…ring Summary: Replace the numerical output for compaction_style and compaction_pri with strings Test Plan: Manually tested: before: 2017/01/25-13:17:42.948086 7f09a3da59c0 Options.compaction_style: 0 2017/01/25-13:17:42.948087 7f09a3da59c0 Options.compaction_pri: 0 after: 2017/01/25-13:56:01.275769 7f716b9939c0 Options.compaction_style: level 2017/01/25-13:56:01.275770 7f716b9939c0 Options.compaction_pri: by compensated size Reviewers: sdong Subscribers: nathro Differential Revision: https://phabricator.intern.facebook.com/D4464638 Tasks: 11090832
|
@highker updated the pull request - view changes - changes since last import |
|
@highker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ring
Summary:
Replace the numerical output for compaction_style and compaction_pri
with strings
Test Plan:
Manually tested:
before:
2017/01/25-13:17:42.948086 7f09a3da59c0 Options.compaction_style: 0
2017/01/25-13:17:42.948087 7f09a3da59c0 Options.compaction_pri: 0
after:
2017/01/25-13:56:01.275769 7f716b9939c0 Options.compaction_style: level
2017/01/25-13:56:01.275770 7f716b9939c0 Options.compaction_pri: by compensated size