Fix repair issues #1858
Closed
Fix repair issues #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can find the true minimum otherwise everything is larger than zero. Fix the comparator name comparision.
|
This addresses #1750 |
ajkr
reviewed
Feb 10, 2017
db/repair_test.cc
Outdated
| @@ -253,7 +253,9 @@ TEST_F(RepairTest, RepairColumnFamilyOptions) { | |||
| db_->GetPropertiesOfAllTables(handles_[1], &fname_to_props); | |||
| ASSERT_EQ(fname_to_props.size(), 2U); | |||
| for (const auto& fname_and_props : fname_to_props) { | |||
| ASSERT_EQ(InternalKeyComparator(rev_opts.comparator).Name(), | |||
| std::string compName (InternalKeyComparator(rev_opts.comparator).Name()); | |||
There was a problem hiding this comment.
would you mind changing to lower-case underscore-separated variable naming?
| @@ -486,6 +486,7 @@ class Repairer { | |||
| if (empty) { | |||
| empty = false; | |||
| t->meta.smallest.DecodeFrom(key); | |||
| t->min_sequence = parsed.sequence; | |||
There was a problem hiding this comment.
Thanks! Looks like this bug has been here a few years. I guess we made the assertions stronger recently and missed it due to repair_test not included in our test suite (will fix that now).
|
@yuslepukhin updated the pull request - view changes |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record the first parsed sequence number as the minimum
so we can find the true minimum otherwise everything is larger than zero.
Fix the comparator name comparision.